bgpd: fix "bgp as-pah access-list" with "set aspath exclude" set/unset issue #15838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdumontet6WIND
force-pushed
the
fix_regexx_exclude
branch
from
c2de26f to
aa365a9
Compare
donaldsharp
reviewed
Apr 25, 2024
fdumontet6WIND
force-pushed
the
fix_regexx_exclude
branch
from
aa365a9 to
691d05e
Compare
fdumontet6WIND
force-pushed
the
fix_regexx_exclude
branch
4 times, most recently
from
3905f36 to
52c04d6
Compare
|
@Mergifyio backport stable/10.0 |
✅ Backports have been created
|
fdumontet6WIND
force-pushed
the
fix_regexx_exclude
branch
from
52c04d6 to
cb69832
Compare
|
ci:rerun |
ton31337
reviewed
May 2, 2024
fdumontet6WIND
force-pushed
the
fix_regexx_exclude
branch
from
cb69832 to
0737bf8
Compare
|
ci:rerun |
fdumontet6WIND
force-pushed
the
fix_regexx_exclude
branch
from
0737bf8 to
6e4b42f
Compare
|
ci:rerun |
fdumontet6WIND
force-pushed
the
fix_regexx_exclude
branch
from
6e4b42f to
9c3c225
Compare
ton31337
reviewed
May 5, 2024
fdumontet6WIND
force-pushed
the
fix_regexx_exclude
branch
from
9c3c225 to
a653cce
Compare
fdumontet6WIND
force-pushed
the
fix_regexx_exclude
branch
from
a653cce to
06dea23
Compare
fdumontet6WIND
force-pushed
the
fix_regexx_exclude
branch
from
06dea23 to
5361f90
Compare
ton31337
reviewed
May 16, 2024
…t issues whith the following config router bgp 65001 no bgp ebgp-requires-policy neighbor 192.168.1.2 remote-as external neighbor 192.168.1.2 timers 3 10 ! address-family ipv4 unicast neighbor 192.168.1.2 route-map r2 in exit-address-family exit ! bgp as-path access-list FIRST seq 5 permit ^65 bgp as-path access-list SECOND seq 5 permit 2$ ! route-map r2 permit 6 match ip address prefix-list p2 set as-path exclude as-path-access-list SECOND exit ! route-map r2 permit 10 match ip address prefix-list p1 set as-path exclude 65003 exit ! route-map r2 permit 20 match ip address prefix-list p3 set as-path exclude all exit making some no bgp as-path access-list SECOND permit 2$ bgp as-path access-list SECOND permit 3$ clear bgp * no bgp as-path access-list SECOND permit 3$ bgp as-path access-list SECOND permit 2$ clear bgp * will induce some crashes thus we rework the links between aslists and aspath_exclude Signed-off-by: Francois Dumontet <francois.dumontet@6wind.com>
add some match in route map rules add some set unset bgp access path list add another prefix for better tests discrimination update expected results Signed-off-by: Francois Dumontet <francois.dumontet@6wind.com>
fdumontet6WIND
force-pushed
the
fix_regexx_exclude
branch
from
5361f90 to
0df2e14
Compare
donaldsharp
reviewed
May 17, 2024
|
|
||
| void as_exclude_remove_orphan(struct aspath_exclude *ase) | ||
| { | ||
| if (as_list_list_count(&as_exclude_list_orphan)) |
There was a problem hiding this comment.
Why is it necessary to have this test? Why not just delete it?
There was a problem hiding this comment.
orphan list may be destroyed before the as_path_exclude that we are destroying currently.
this occurs at termination time.
this test verify the existence of the list .
riw777
approved these changes
May 20, 2024
|
I think we need to address @donaldsharp 's comment before merging (?) |
|
Are you interested in this fix? |
@donaldsharp just wanted to check it before we merge ... |
|
@Mergifyio backport dev/10.1 |
✅ Backports have been created
|
riw777
added a commit
that referenced
this pull request
Jun 25, 2024
bgpd: fix "bgp as-pah access-list" with "set aspath exclude" set/unset issue (backport #15838)
riw777
added a commit
that referenced
this pull request
Jun 25, 2024
bgpd: fix "bgp as-pah access-list" with "set aspath exclude" set/unset issue (backport #15838)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bgpd: fix "bgp as-pah access-list" with "set aspath exclude" set/unset issues
whith the following config
router bgp 65001
no bgp ebgp-requires-policy
neighbor 192.168.1.2 remote-as external
neighbor 192.168.1.2 timers 3 10
!
address-family ipv4 unicast
neighbor 192.168.1.2 route-map r2 in
exit-address-family
exit
!
bgp as-path access-list FIRST seq 5 permit ^65
bgp as-path access-list SECOND seq 5 permit 2$
!
route-map r2 permit 6
match ip address prefix-list p2
set as-path exclude as-path-access-list SECOND
exit
!
route-map r2 permit 10
match ip address prefix-list p1
set as-path exclude 65003
exit
!
route-map r2 permit 20
match ip address prefix-list p3
set as-path exclude all
exit
making some
no bgp as-path access-list SECOND permit 2$
bgp as-path access-list SECOND permit 3$
clear bgp *
no bgp as-path access-list SECOND permit 3$
bgp as-path access-list SECOND permit 2$
clear bgp *
will induce some crashes
thus we rework the links between aslists and aspath_exclude
Signed-off-by: Francois Dumontet francois.dumontet@6wind.com